This repository has been archived by the owner on Dec 27, 2023. It is now read-only.
Add filter by tag command #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add filter command to allow users to list all contacts matching a certain Tag (case insensitive). Tests and documentation update to follow.
Codecov Report
@@ Coverage Diff @@
## master #126 +/- ##
============================================
+ Coverage 71.46% 72.31% +0.85%
- Complexity 369 387 +18
============================================
Files 69 72 +3
Lines 1265 1304 +39
Branches 119 124 +5
============================================
+ Hits 904 943 +39
Misses 325 325
Partials 36 36
|
|
I think you need to add tests for the code added to pass the checks |
Yep I'll do that soon as mentioned above |
Ah I forgot to mark this as draft PR (I thought I did) |
|
Linking #107. |
Add test coverage for filter command.
rayshawntan
approved these changes
Oct 30, 2023
Cloud7050
approved these changes
Oct 30, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add filter command to allow users to list all contacts matching a certain Tag (case insensitive).
Documentation update will be done in a separate PR together with other documentation updates (addresses #127 instead).
Closes #107.